Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixing a typo in 03-installation.mdx and improving grammar in 2 other files for readability #144

Merged
merged 3 commits into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apps/docs/docs/learn/02-thinking-in-stylex.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Most existing solutions to this problem rely on rules and conventions.
constraints on where and how styles can be applied, putting architectural limitations on styling.
</details>

StyleX aims to improve on both the consistency and predictability of styles
StyleX aims to improve both the consistency and predictability of styles
_and_ the expressive power available. We believe this is possible through
build-tools.

Expand Down Expand Up @@ -181,8 +181,8 @@ At its core, StyleX can be boiled down to two functions:
those styles to an element.

Within these two functions, we choose to rely on common JS patterns rather than
introduce unique API or patterns for StyleX. For example, we don't have an API for
conditional styles. Instead we support applying styles conditionally with
introduce unique APIs or patterns for StyleX. For example, we don't have an API for
conditional styles. Instead, we support applying styles conditionally with
boolean or ternary expressions.

Things should work as expected when dealing with JavaScript objects and arrays.
Expand Down Expand Up @@ -248,7 +248,7 @@ type Props = {
};
```

Styles being typed enables extremely sophisticated rules about the ways in which
Styles being typed enables extremely sophisticated rules about how
a component's styles can be customized with **zero-runtime cost**.

### Shareable constants
Expand Down Expand Up @@ -294,11 +294,11 @@ distance":
- `.className ~ *`
- `.className:hover > div:first-child`

All of these patterns, while powerful, makes styles fragile and less predictable.
All of these patterns, while powerful, make styles fragile and less predictable.
Applying class names on one element can affect a completely different element.

Inheritable styles such as `color` will still be inherited, but that is the
_only_ form of style-at-a-distance that StyleX allows. And in those cases too,
_only_ form of style-at-a-distance that StyleX allows. In those cases too,
the styles applied directly on an element always take precedence over inherited
styles.

Expand Down
2 changes: 1 addition & 1 deletion apps/docs/docs/learn/03-installation.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ done with any bundler that supports Babel, using the metadata generated by the
StyleX plugin. See the API reference for more details on the
`@stylexjs/babel-plugin` API.

To make this easier for commonly used packagers and meta-frameworks, StyleX
To make this easier for commonly used packages and meta-frameworks, StyleX
provides plugins for Webpack, Rollup, and Next.js.

<details>
Expand Down
2 changes: 1 addition & 1 deletion apps/docs/docs/learn/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ title: Introduction

# Introduction to StyleX

StyleX is a simple, easy to use JavaScript syntax and compiler for styling web
StyleX is a simple, easy-to-use JavaScript syntax and compiler for styling web
apps.

StyleX combines the strengths and avoids the weaknesses of both inline styles
Expand Down
Loading