Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fixing a typo in 03-installation.mdx and improving grammar in 2 other files for readability #144

Merged
merged 3 commits into from
Dec 12, 2023
Merged

docs: Fixing a typo in 03-installation.mdx and improving grammar in 2 other files for readability #144

merged 3 commits into from
Dec 12, 2023

Conversation

nelsonuprety1
Copy link
Contributor

What changed / motivation ?

In this pull request, I corrected a typo identified in the 03-installation.mdx file. Additionally, I addressed grammar issues in two other files to improve the overall readability of the document.

Linked PR/Issues

Additional Context

  • The typo fix in the 03-installation.mdx file relates to a critical step in the installation process, improving user guidance.
  • Grammar corrections in the two additional files will make the content more readable.
  • These changes align with the project's style guide and documentation standards, ensuring consistency across the codebase.

Pre-flight checklist

@facebook-github-bot
Copy link

Hi @nelsonuprety1!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@nelsonuprety1
Copy link
Contributor Author

I have successfully signed the Contributor License Agreement. Thank You.

nmn
nmn reviewed Dec 12, 2023
View reviewed changes
apps/docs/docs/learn/02-thinking-in-stylex.mdx Outdated
@@ -46,11 +46,11 @@ Most existing solutions to this problem rely on rules and conventions.
<details>
<summary>Utility Classes</summary>
Atomic utility class names like Tailwind CSS and Tachyons rely on conventions and lint rules
to ensure that conflicting class names are not applied on the same element. Such tooling adds
to ensure that conflicting class names are not applied to the same element. Such tooling adds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was originally correct.

nmn
nmn reviewed Dec 12, 2023
View reviewed changes
apps/docs/docs/learn/02-thinking-in-stylex.mdx Outdated
@@ -162,7 +162,7 @@ function MyComponent({style}) {
This is a little more code, but the runtime cost is still minimal
because of how fast the `stylex.props()` function is.

Most other styling solutions don't enable composition of styles across file
Most other styling solutions don't enable the composition of styles across file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This the changes the meaning and is wrong here.

nmn
nmn requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the changes are regressions. I've commented on them

@nelsonuprety1
Update 02-thinking-in-stylex.mdx as per the request
b630e1a 
I have fixed the suggested changes. Thank you
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 12, 2023
@nelsonuprety1
Copy link
Contributor Author

@nmn i have updated the files with the changes that you suggested. Please kindly check thank you.

@nmn nmn merged commit 31bc58c into facebook:main Dec 12, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmn nmn nmn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nelsonuprety1 @facebook-github-bot @nmn