Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some deprecation warnings #306

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Add some deprecation warnings #306

merged 5 commits into from
Apr 12, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Apr 12, 2024

Resolves #293. Changes:

  • Uses @deprecated decorator from deprecated library. This is a small library with a single dependency, and the ability to add deprecation notices to Sphinx-generated docs is a fairly good justification for adding a dependency.
  • Adds a couple of unit tests.

@sajith sajith requested review from paul-ruth and kthare10 April 12, 2024 21:58
@coveralls
Copy link
Collaborator

coveralls commented Apr 12, 2024

Pull Request Test Coverage Report for Build 8668449895

Details

  • 23 of 23 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.1%) to 24.056%

Totals Coverage Status
Change from base Build 8559162669: 2.1%
Covered Lines: 1273
Relevant Lines: 4722

💛 - Coveralls

We're a library after all
Copy link
Collaborator

@kthare10 kthare10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sajith sajith merged commit 47df32e into main Apr 12, 2024
14 checks passed
@sajith sajith deleted the 239.deprecation-warnings branch April 12, 2024 22:33
@nbastin
Copy link

nbastin commented Apr 12, 2024

These tests can't possibly fail. This is not ok.

@kthare10
Copy link
Collaborator

@sajith - The deprecated function get_physical_os_device_name() is being used by several list/show functions within fablib. Please verify changing it to the newer function that's suggested and update the code accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated methods don't warn with DeprecationWarning
4 participants