293.remove usage of deprecated

[sajith]

Follow-up to #306, which added deprecation warnings to three methods, but we've been calling those allegedly deprecated methods internally. I failed to check for those usages, so I'm going around looking for where we've been using them.

1. Interface.get_os_interface(), which has a simple replacement in get_device_name(), so I replaced all calls accordingly. Haven't actually tested this from a notebook, because I'm unsure what the replacements for the other two should be.

2. Node.set_ip_os_interface() is called by Interface.set_ip(), which itself should be deprecated. I did not catch it in the previous pass because of the typo in comment ("Depricated" instead of "deprecated"), and I'm not sure what should replace either of these methods.

3. Node.add_vlan_os_interface() is called by Interface.config_vlan_interface() (which is not intended for API use), which is called by Slice.post_boot_config(). Again, I'm not sure what should replace Node.add_vlan_os_interface().

Help, @kthare10 and @paul-ruth? :-)

[coveralls]

Pull Request Test Coverage Report for Build 8698941792

Details

• 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage remained the same at 24.056%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
fabrictestbed_extensions/fablib/slice.py	0	1	0.0%
fabrictestbed_extensions/fablib/interface.py	0	5	0.0%

Files with Coverage Reduction	New Missed Lines	%
fabrictestbed_extensions/fablib/slice.py	1	8.42%

Totals
Change from base Build 8668730359:	0.0%
Covered Lines:	1273
Relevant Lines:	4722

---

💛 - Coveralls