Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slice sharing #281

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Slice sharing #281

merged 9 commits into from
Jan 29, 2024

Conversation

kthare10
Copy link
Collaborator

Slice sharing and execution time improvement for get_ssh_command
#280
#279

@kthare10 kthare10 self-assigned this Jan 29, 2024
This was linked to issues Jan 29, 2024
Allow access to other user's slices in a project #279
Closed
Reduce the time taken for the call node.get_ssh_command() #280
Closed
@coveralls
Copy link
Collaborator

coveralls commented Jan 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7703648034

  • -23 of 29 (20.69%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 22.221%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fabrictestbed_extensions/fablib/node.py 2 4 50.0%
fabrictestbed_extensions/fablib/fablib.py 2 8 25.0%
fabrictestbed_extensions/fablib/slice.py 2 17 11.76%
Totals Coverage Status
Change from base Build 7671423760: -0.02%
Covered Lines: 1159
Relevant Lines: 4650
💛 - Coveralls

@kthare10 kthare10 requested review from paul-ruth and sajith January 29, 2024 20:53
sajith
sajith approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@sajith sajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kthare10 kthare10 merged commit 986f8d8 into main Jan 29, 2024
14 checks passed
@kthare10 kthare10 deleted the slice-sharing branch January 29, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-ruth paul-ruth paul-ruth approved these changes

@sajith sajith sajith approved these changes

Assignees

@kthare10 kthare10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce the time taken for the call node.get_ssh_command() Allow access to other user's slices in a project
4 participants
@kthare10 @coveralls @sajith @paul-ruth