Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing addresses on modify #264

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Missing addresses on modify #264

merged 5 commits into from
Dec 14, 2023

Conversation

sajith
Copy link
Member

@sajith sajith commented Dec 13, 2023

Resolves #261.

@sajith sajith mentioned this pull request Dec 13, 2023
Closed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7200322322

  • 1 of 7 (14.29%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 19.993%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fabrictestbed_extensions/fablib/slice.py 1 7 14.29%
Totals Coverage Status
Change from base Build 6695101431: 0.01%
Covered Lines: 976
Relevant Lines: 4345
💛 - Coveralls

@sajith sajith self-assigned this Dec 13, 2023
kthare10
kthare10 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@kthare10 kthare10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sajith sajith merged commit 8f698c6 into main Dec 14, 2023
13 checks passed
@sajith sajith deleted the 261.missing-addresses-on-modify branch December 14, 2023 15:55
@sajith sajith mentioned this pull request Dec 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kthare10 kthare10 kthare10 approved these changes

@hussamnasir hussamnasir Awaiting requested review from hussamnasir

@paul-ruth paul-ruth Awaiting requested review from paul-ruth

Assignees

@sajith sajith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

postboot on slice update/modify not working properly
3 participants
@sajith @coveralls @kthare10