Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing IP addresses on modify #262

Closed
wants to merge 60 commits into from
Closed

Missing IP addresses on modify #262

wants to merge 60 commits into from

Conversation

sajith
Copy link
Member

@sajith sajith commented Nov 8, 2023

Investigating #261.

@coveralls
Copy link
Collaborator

coveralls commented Nov 8, 2023

Pull Request Test Coverage Report for Build 7039014048

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 19.98%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fabrictestbed_extensions/fablib/interface.py 0 1 0.0%
Totals Coverage Status
Change from base Build 6695101431: -0.003%
Covered Lines: 975
Relevant Lines: 4344

💛 - Coveralls

sajith added 24 commits November 9, 2023 16:28
stdout (and stderr) are likely to be unset here if code in the try
block raised an exception.

This happened when investigating #261: dev happened to be None, which
led to:

[11:56:43] {fablib/node.py:1333} DEBUG - execute node: meas-node, management_ip: None, command: sudo  ip -j addr list
[11:56:43] {fablib/node.py:1339} DEBUG - Execute failed. Node meas-node in state Ticketed
[11:56:43] {fablib/node.py:1344} DEBUG - Execute failed. Node meas-node in management IP  None
[11:56:43] {fablib/node.py:1364} ERROR - node.execute: Management IP Invalid:
NoneType: None
[11:56:43] {fablib/node.py:2236} DEBUG - Failed to get ip addr list: node.execute: Management IP Invalid: None
[11:56:43] {fablib/node.py:1333} DEBUG - execute node: meas-node, management_ip: None, command: ip -j addr show None
[11:56:43] {fablib/node.py:1339} DEBUG - Execute failed. Node meas-node in state Ticketed
[11:56:43] {fablib/node.py:1344} DEBUG - Execute failed. Node meas-node in management IP  None
[11:56:43] {fablib/node.py:1364} ERROR - node.execute: Management IP Invalid:
NoneType: None
[11:56:43] {fablib/interface.py:722} ERROR - Failed to get ip addr show info for interface meas-node-meas_nic_meas-node_EDC-p1
[11:56:43] {usr/lib/python3.11/asyncio/selector_events.py:54} DEBUG - Using selector: EpollSelector

#261
@sajith sajith changed the title Management IPs missing on measurement nodes Missing IP addresses on modify Nov 28, 2023
@sajith
Copy link
Member Author

sajith commented Dec 13, 2023

Closing, favoring #264. This branch grew tentacles.

@sajith sajith closed this Dec 13, 2023
@sajith sajith deleted the 261.l2-measurement-node branch December 13, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants