Remove token from local storage and store it as global variable

packages/prosemirror-lwdita-demo/cypress/e2e/github-inegration.cy.ts

@@ -126,10 +126,6 @@ describe('request the token after OAuth', () => {
     // Verify that the token request was made
     cy.get('@requestToken').should('have.property', 'response');
     cy.get('@requestToken').its('response.statusCode').should('eq', 200);
-
-    cy.getAllLocalStorage().then((result) => {
-      expect(result['http://localhost:1234']).to.have.property('token');
-    })
   });
 
   it('should show an error when the token request fails', () => {

packages/prosemirror-lwdita/src/github-integration/github.plugin.ts

@@ -22,6 +22,7 @@ import { showToast } from "../toast";
 import { Config } from "../config";
 import { Localization } from "@evolvedbinary/prosemirror-lwdita-localization";
 import urijs from "urijs";
+import { Global } from '../global'
 
 /**
  * Fetches the raw content of a document from a GitHub repository.
@@ -158,7 +159,9 @@ export const getUserInfo = async (config: Config, localization: Localization, to
  * @returns A promise that resolves when the document has been published.
  */
 export const createPrFromContribution = async (config: Config, localization: Localization, ghrepo: string, source: string, branch: string, changedDocument: string, title: string, desc: string): Promise<string> => {
-  const authenticatedUserInfo = await getUserInfo(config, localization, localStorage.getItem('token') as string);
+  const token = (global as Global).token;
+
+  const authenticatedUserInfo = await getUserInfo(config, localization, token);
 
   const owner = ghrepo.split('/')[0];
   const repo = ghrepo.split('/')[1];
@@ -173,8 +176,7 @@ export const createPrFromContribution = async (config: Config, localization: Loc
     content
   };
   const body = `${desc}` + config.git.commitMessageSuffix;
-  // get the token from the local storage
-  const token = localStorage.getItem('token');
+
   // make a post request to  /api/github/integration
   const response = await fetch(config.server.api.baseUrl + config.server.api.endpoint.integration, {
     method: 'POST',

packages/prosemirror-lwdita/src/github-integration/request.ts

@@ -19,6 +19,7 @@ import { exchangeOAuthCodeForAccessToken } from './github.plugin';
 import { showToast } from '../toast';
 import { Config } from '../config';
 import { Localization } from '@evolvedbinary/prosemirror-lwdita-localization';
+import { Global } from '../global'
 
 /**
  * Interface for the URL parameters
@@ -217,7 +218,7 @@ export function processRequest(config: Config, localization: Localization): unde
           }
 
           exchangeOAuthCodeForAccessToken(config, localization, returnParams.code).then(({token, installation}) => {
-            localStorage.setItem('token', token); 
+            (global as Global).token = token;
             if(!installation) {
               // redirect to the OAuth error page and show the error message with instructions to install the app
               redirectToGitHubAppInstall(config, returnParams);

packages/prosemirror-lwdita/src/global.d.ts

@@ -0,0 +1,31 @@
+/* eslint-disable no-var */
+/*!
+Copyright (C) 2020 Evolved Binary
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU Affero General Public License as
+published by the Free Software Foundation, either version 3 of the
+License, or (at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU Affero General Public License for more details.
+
+You should have received a copy of the GNU Affero General Public License
+along with this program.  If not, see <https://www.gnu.org/licenses/>.
+*/
+
+
+// This file is used to declare global variables that are used in the application.
+// This is a workaround to allow the use of global variables in TypeScript.
+// See https://javascript.plainenglish.io/typescript-and-global-variables-in-node-js-59c4bf40cb31
+export interface Global {
+  token: string;
+}
+
+// The use of `var` is intentional here, as it is the only way to declare a global variable in TypeScript.
+declare global {
+  var token: string;
+}
+export { };

packages/prosemirror-lwdita/tests/github.plugin.spec.ts

@@ -21,6 +21,7 @@ import fetchMock from 'fetch-mock';
 import { shortXdita, shortXditaProsemirroJson } from './test-utils';
 import { MockConfig } from './mock.config';
 import { createLocalization } from '@evolvedbinary/prosemirror-lwdita-localization';
+import { Global } from '../src/global'
 
 const config = new MockConfig();
 const localization = createLocalization();
@@ -116,15 +117,6 @@ describe('getUserInfo', () => {
 });
 
 describe('createPrFromContribution', () => {
-  beforeEach(() => {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    const window = global as any;
-    Object.defineProperty(window, 'localStorage', {
-      value: {
-        getItem: () => 'mock-token',
-      },
-    });
-  });
   afterEach(() => {
     fetchMock.restore();
   });
@@ -151,6 +143,7 @@ describe('createPrFromContribution', () => {
         login: petalBotUser,
       },
     });
+    (global as Global).token = token;
     await createPrFromContribution(config, localization, ghrepo, source, branch, changedDocument, title, description);
     const lastCall = fetchMock.lastCall(config.server.api.baseUrl + config.server.api.endpoint.integration) as fetchMock.MockCall;
     if (!lastCall) {