Remove token from local storage and store it as global variable #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmoure
force-pushed
the
feature/token-as-global
branch
6 times, most recently
from
c44ce3c to
dd8979d
Compare
marmoure
force-pushed
the
feature/token-as-global
branch
from
dd8979d to
9aa7488
Compare
adamretter
reviewed
Nov 26, 2024
| // This file is used to declare global variables that are used in the application. | ||
| // This is a workaround to allow the use of global variables in TypeScript. | ||
| // See https://javascript.plainenglish.io/typescript-and-global-variables-in-node-js-59c4bf40cb31 | ||
| export interface Global { |
There was a problem hiding this comment.
Why do we also need this? I read the article that you pointed to but they don't do this.
There was a problem hiding this comment.
The interface is for setting the type
const token = (global as Global).token;when using the global var on it's own it's does not types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The user token we got back from GitHub is stored in Local Storage, this can pose a security risk.
The fix
The user token will only be stored in memory
How to test this