Updates for Xtensa enabled 1.83 compiler #2615
Conversation
MabezDev
force-pushed
the
compiler-test
branch
from
2b680a0 to
a6c5233
Compare
MabezDev
changed the title
.github/workflows/ci.yml
Outdated
| @@ -70,6 +70,7 @@ jobs: | |||
| - uses: esp-rs/[email protected] | |||
| with: | |||
| ldproxy: false | |||
| version: 1.83.0.0 | |||
There was a problem hiding this comment.
TODO remove these once CI goes green and post compiler release
| @@ -772,7 +772,7 @@ fn lint_package(path: &Path, args: &[&str], fix: bool) -> Result<()> { | |||
| // build in release to reuse example artifacts | |||
| let cargo_args = builder.arg("--release"); | |||
| let cargo_args = if fix { | |||
| cargo_args.arg("--fix").arg("--lib") | |||
| cargo_args.arg("--fix").arg("--lib").arg("--allow-dirty") | |||
There was a problem hiding this comment.
Thank you, keep forgetting to add this 😅
|
Any updates here? |
|
Nothing yet, the LLVM issue is being looked into still. Our last resort is still available, which is to bump the MSRV. |
|
Issue is fixed 🎉 , needs to make its way to github and I'll start the release builds |
MabezDev
force-pushed
the
compiler-test
branch
from
ba8ce42 to
8bf4031
Compare
MabezDev
force-pushed
the
compiler-test
branch
from
8bf4031 to
41a877b
Compare
|
Well, it's fixed... but we're still in a situation where MSRV is failing because the bug that I found whilst trying to avoid bumping MSRV also affects the MSRV toolchain 🙃. I think we have a few options here:
Thoughts? |
|
Getting rid of naked functions sounds best to me. Not ideal to bump MSRV to 1.83 however. Not sure how much effort option 3 would be |
| @@ -20,7 +20,7 @@ use crate::cfg_asm; | |||
| // `Context` struct in context.rs | |||
| global_asm!( | |||
| " | |||
| .set XT_STK_PC, 0 | |||
| .set XT_STK_PC, 0 | |||
There was a problem hiding this comment.
Obviously nothing important, but what did that one space do to you? :D
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Please provide a clear and concise description of your changes, including the motivation behind these changes. The context is crucial for the reviewers.
Testing
Describe how you tested your changes.