Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sqlite3mc and e_sqlite3mc to build process #19

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

utelle
Copy link
Contributor

@utelle utelle commented Nov 8, 2023

Integrate SQLite3 Multiple Ciphers into SQLitePCLraw

  • Add source files in directory sqlite3mc
  • Add functions to generate build files for sqlite3mc and e_sqlite3mc to bld/cb.cs
  • Adjust GitHub workflow
  • Adjust README.md

@bricelam
Copy link
Contributor

bricelam commented Nov 9, 2023

I'm just using the binaries for sqlite3mc in ericsink/SQLitePCL.raw#563. Is there a difference between them and e_sqlite3mc?

@utelle
Copy link
Contributor Author

utelle commented Nov 9, 2023

I'm just using the binaries for sqlite3mc in ericsink/SQLitePCL.raw#563. Is there a difference between them and e_sqlite3mc?

Except for the name there is no difference.

The build files coming with SQLite3 Multiple Ciphers use the library name sqlite3mc. Therefore it may be better to use the name e_sqlite3mc in the .NET packages to avoid potential name clashes, if users install both.

@ericsink
Copy link
Owner

ericsink commented Nov 9, 2023

I am always a bit amazed when someone else works on cb.cs. It is not a thing of beauty.

@ericsink ericsink merged commit dc0e393 into ericsink:master Nov 9, 2023
8 checks passed
@utelle
Copy link
Contributor Author

utelle commented Nov 9, 2023

I am always a bit amazed when someone else works on cb.cs. It is not a thing of beauty.

I have to admit that I chose a somewhat "quick&dirty" approach to make the code "work". IMHO the code should be cleaned up a bit, as soon as we have decided, which library name will be used for the NuGet packages - sqlite3mc or e_sqlite3mc.

Actually, I used a copy of the function write_e_sqlite3() as a template for write_e_sqlite3mc() and write_sqlite3mc() .
Most likely the #if not ... #endif sections can be removed. Regarding white space either blanks or tabs should be used, not a mixture.

@utelle utelle deleted the add-sqlite3mc-to-cb branch November 12, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants