-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add packages for SQLite3 Multiple Ciphers #563
Conversation
"sdk": | ||
{ | ||
"version": "6.0.100", | ||
"rollForward": "latestFeature" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to make the repo easier to work with locally. It won't use the .NET 8 SDK which errors for net6.0-ios and android targets. It reflects the 6.0.x semantics in the GitHub action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been adding something similar to my local work directory.
I'm a little bit tempted to deprecate net6.0 next week.
But net6.0 is still in support for another year.
But the net6.0 mobile targets are a special case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I'm confessing my temptations, I'd love to deprecate support for .NET Framework too, but that's a whole different can of worms. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our fork, I compromised by supporting the base net6.0 TFM, but requiring net7.0-android and -ios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still want .NET Framework support, but only for VS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speaking broadly, not just about SQLite...
I always wonder how the support story for .NET Framework would be different without VS in the picture. I assume it'll probably never move to [.NET Core and its descendants]. Lots of enterprise apps are in the same boat, but VS is a special case.
No comments expected -- I'm just musing a bit.
I’ll update this to use the |
I've reviewed these diffs and I don't see any obvious problems. I do think the The PR for |
Updated to prefix with "e_". I also added a provider (but no bundle) package without the prefix to enable using the version installed from source (and any future OS packages). |
Looks like you still need to merge from |
Oops! I thought I did that... done. I'll rerun the checks. |
|
Hmmm. And this error wasn't happening when you ran the test suite using the builds you grabbed from the cb fork? |
I was using the binaries from the |
I see reasons to ask questions about how the heap limit functions might have different behavior for sqlite3mc. But I see nothing to explain why the error wasn't happening for you before. It's like something is different about the new builds from the merged |
I pushed a commit into this PR to disable the failing tests, just for now. |
I have absolutely no idea. What I can say is that sqlite3mc does not actively interfer with the heap limits. sqlite3mc implements a VFS shim which sits between SQLite and the real VFS. If encryption is not enabled it passes the page data through to the real VFS unchanged.
I will try to perform this heap limit test directly with sqlite3mc alone, outside of any .NET environment. |
Depends on ericsink/cb#19
/cc @utelle