Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Add torque #101

Closed
wants to merge 1 commit into from
Closed

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Sep 4, 2024

Add TORQUE option to Everest

Closes #99

@yngve-sk yngve-sk marked this pull request as draft September 4, 2024 10:23
@yngve-sk yngve-sk force-pushed the add-pbstorque-driver-option branch from d7c958e to 2ac2f18 Compare September 4, 2024 10:24
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (29ace2b) to head (525d624).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
src/everest/queue_driver/queue_driver.py 33.33% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (29ace2b) and HEAD (525d624). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (29ace2b) HEAD (525d624)
test 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #101       +/-   ##
===========================================
- Coverage   89.79%   69.43%   -20.37%     
===========================================
  Files          86       86               
  Lines        5049     5074       +25     
===========================================
- Hits         4534     3523     -1011     
- Misses        515     1551     +1036     
Flag Coverage Δ
integration-test 65.70% <92.00%> (-0.04%) ⬇️
test ?
ui-test 87.03% <ø> (+4.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk force-pushed the add-pbstorque-driver-option branch 8 times, most recently from 9f59ff3 to 695737a Compare September 4, 2024 11:46
@yngve-sk yngve-sk marked this pull request as ready for review September 4, 2024 11:49
@yngve-sk yngve-sk force-pushed the add-pbstorque-driver-option branch 3 times, most recently from f686d05 to 55d89b0 Compare September 4, 2024 11:56
Comment on lines 121 to 131
qsub_cmd: Optional[str] = Field(default="qsub")
qstat_cmd: Optional[str] = Field(default="qstat")
qdel_cmd: Optional[str] = Field(default="qdel")
qstat_options: Optional[str] = Field(default="-x")
cluster_label: Optional[str] = Field(default=None)
num_nodes: Optional[int] = Field(default=1)
memory_per_job: Optional[str] = Field(default=None)
keep_qsub_output: Optional[int] = Field(default=0)
submit_sleep: Optional[float] = Field(default=0.5)
queue_query_timeout: Optional[int] = Field(default=126)
project_code: Optional[str] = Field(default=None)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a small description for these fields.

@yngve-sk yngve-sk force-pushed the add-pbstorque-driver-option branch 2 times, most recently from fdb1438 to ff6da3a Compare September 6, 2024 09:44
@yngve-sk
Copy link
Contributor Author

yngve-sk commented Sep 6, 2024

Did paste in some of the docs from ERT. Currently testing out on AZ / torque and it doesn't seem to work at the moment, will need some more time debugging it

Add TORQUE option to Everest
@yngve-sk yngve-sk force-pushed the add-pbstorque-driver-option branch from ff6da3a to 525d624 Compare September 9, 2024 06:39
@yngve-sk
Copy link
Contributor Author

Continued @ equinor/ert#8854

@yngve-sk yngve-sk closed this Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create PBS/TORQUE driver to have the 'pbs' queue system option
3 participants