Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torque support to Everest #8854

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Oct 3, 2024

Resolves equinor/everest#99
Tested on S034 AZ node through, seems to work.

Issue
Adds torque to Everest, port-over of equinor/everest#101

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@yngve-sk yngve-sk force-pushed the add-torque-to-everest branch 5 times, most recently from ab84e95 to 4ea15f7 Compare October 3, 2024 07:01
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (da9495d) to head (a0d8777).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8854      +/-   ##
==========================================
- Coverage   91.55%   91.54%   -0.01%     
==========================================
  Files         347      347              
  Lines       21397    21397              
==========================================
- Hits        19589    19588       -1     
- Misses       1808     1809       +1     
Flag Coverage Δ
cli-tests 39.60% <ø> (ø)
gui-tests 73.55% <ø> (-0.03%) ⬇️
performance-tests 50.19% <ø> (-0.03%) ⬇️
unit-tests 80.10% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk force-pushed the add-torque-to-everest branch 2 times, most recently from 4df459f to 8706bcf Compare October 3, 2024 10:52
@yngve-sk yngve-sk force-pushed the add-torque-to-everest branch 4 times, most recently from 39f65ba to f1a2a97 Compare October 18, 2024 07:26
@yngve-sk yngve-sk force-pushed the add-torque-to-everest branch from f1a2a97 to 8db021b Compare October 18, 2024 07:55
@yngve-sk yngve-sk marked this pull request as ready for review October 18, 2024 07:56
@yngve-sk yngve-sk force-pushed the add-torque-to-everest branch from 8db021b to a0d8777 Compare October 18, 2024 08:00
@yngve-sk yngve-sk self-assigned this Oct 18, 2024
@yngve-sk yngve-sk requested a review from verveerpj October 18, 2024 09:43
Copy link
Contributor

@verveerpj verveerpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yngve-sk yngve-sk merged commit 0ca8b0b into equinor:main Oct 18, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create PBS/TORQUE driver to have the 'pbs' queue system option
3 participants