Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use IPC protocol for everest #9621

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Do not use IPC protocol for everest #9621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37555ec
Don't use ipc protocol for everest
xjules Dec 23, 2024
fb0854e
Fix empty fail option
xjules Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/everest/detached/jobs/everserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ def main():
optimization_callback=partial(_opt_monitor, shared_data=shared_data),
)
if run_model.ert_config.queue_config.queue_system == QueueSystem.LOCAL:
evaluator_server_config = EvaluatorServerConfig()
evaluator_server_config = EvaluatorServerConfig(use_ipc_protocol=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With zmq, you can opt for using IPC (inter process communication) protocol, which is faster than TCP. This of-course is possible only when using LOCAL_DRIVER. On the other hand, I don't think that it solves the issue.

else:
evaluator_server_config = EvaluatorServerConfig(
custom_port_range=range(49152, 51819), use_ipc_protocol=False
Expand Down
2 changes: 1 addition & 1 deletion test-data/everest/math_func/jobs/fail_simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def main(argv):
arg_parser.add_argument("--fail", type=str)
options, _ = arg_parser.parse_known_args(args=argv)

if options.fail in os.getcwd():
if options.fail is not None and options.fail in os.getcwd():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure this change is needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but otherwise this will fail all the time (ie. each realization), at least that's what I got when testing it

raise Exception(f"Failing {options.fail} by request!")

time.sleep(1)
Expand Down
Loading