Do not use IPC protocol for everest #9621
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #9621 will not alter performanceComparing Summary
|
DanSava
reviewed
Dec 23, 2024
| @@ -306,7 +306,7 @@ def main(): | |||
| optimization_callback=partial(_opt_monitor, shared_data=shared_data), | |||
| ) | |||
| if run_model.ert_config.queue_config.queue_system == QueueSystem.LOCAL: | |||
| evaluator_server_config = EvaluatorServerConfig() | |||
| evaluator_server_config = EvaluatorServerConfig(use_ipc_protocol=False) | |||
There was a problem hiding this comment.
With zmq, you can opt for using IPC (inter process communication) protocol, which is faster than TCP. This of-course is possible only when using LOCAL_DRIVER. On the other hand, I don't think that it solves the issue.
| @@ -19,7 +19,7 @@ def main(argv): | |||
| arg_parser.add_argument("--fail", type=str) | |||
| options, _ = arg_parser.parse_known_args(args=argv) | |||
|
|
|||
| if options.fail in os.getcwd(): | |||
| if options.fail is not None and options.fail in os.getcwd(): | |||
There was a problem hiding this comment.
I am unsure this change is needed.
There was a problem hiding this comment.
Right, but otherwise this will fail all the time (ie. each realization), at least that's what I got when testing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9620
Approach
WIP
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable