Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add box-plots to standard deviation plot #8833

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

xjules
Copy link
Contributor

@xjules xjules commented Oct 1, 2024

Issue
Continuation of #8565

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)
image

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@xjules xjules self-assigned this Oct 1, 2024
@xjules xjules changed the title Std dev box plot Add box-plots to standard deviation plot Oct 1, 2024
@xjules xjules marked this pull request as ready for review October 1, 2024 13:58
@xjules xjules force-pushed the std-dev-box-plot branch 2 times, most recently from 82f5abc to 382b0ef Compare October 2, 2024 07:17
@xjules xjules force-pushed the std-dev-box-plot branch 4 times, most recently from de1210b to efc7094 Compare October 2, 2024 13:09
@xjules
Copy link
Contributor Author

xjules commented Oct 2, 2024

Still getting different results on the ubuntu runner, even with the same matplotlib & python versions
ubuntu
result
RHEL8
baseline

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.41%. Comparing base (f6b86c6) to head (2f7723f).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/gui/plottery/plots/std_dev.py 91.17% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8833      +/-   ##
==========================================
- Coverage   91.41%   91.41%   -0.01%     
==========================================
  Files         343      344       +1     
  Lines       21086    21122      +36     
==========================================
+ Hits        19276    19308      +32     
- Misses       1810     1814       +4     
Flag Coverage Δ
cli-tests 39.63% <0.00%> (+<0.01%) ⬆️
gui-tests 73.55% <91.17%> (+0.04%) ⬆️
performance-tests 50.16% <2.94%> (-0.03%) ⬇️
unit-tests 80.09% <91.17%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xjules xjules force-pushed the std-dev-box-plot branch 2 times, most recently from 4e81b36 to fb9288f Compare October 3, 2024 10:46
dafeda and others added 2 commits October 3, 2024 13:30
- test for stddev plot
- Update baseline image for test_that_all_snake_oil_visualisations_matches_snapshot
- Remove redudant image files

Co-authored by Feda Curic <[email protected]>
@xjules xjules enabled auto-merge (rebase) October 3, 2024 11:34
@xjules xjules merged commit 6d5c0a2 into equinor:main Oct 3, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants