Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add box-plots to standard deviation plot #8565

Closed
wants to merge 3 commits into from

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Aug 23, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.77%. Comparing base (04d8d61) to head (4a33565).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/gui/plottery/plots/std_dev.py 91.17% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8565      +/-   ##
==========================================
+ Coverage   90.68%   90.77%   +0.08%     
==========================================
  Files         342      342              
  Lines       20898    20966      +68     
==========================================
+ Hits        18952    19032      +80     
+ Misses       1946     1934      -12     
Flag Coverage Δ
gui-tests 75.84% <91.17%> (-0.03%) ⬇️
integration-tests 53.94% <2.94%> (-0.09%) ⬇️
unit-tests 68.72% <2.94%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafeda dafeda changed the title Commitin Add box-plots to standard deviation plot Aug 29, 2024
@dafeda dafeda self-assigned this Sep 6, 2024
@xjules xjules assigned xjules and unassigned dafeda Sep 30, 2024
@xjules
Copy link
Contributor

xjules commented Oct 1, 2024

Superseded by #8833

@xjules xjules closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants