Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow for benchmarking #6745

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Add GitHub workflow for benchmarking #6745

merged 3 commits into from
Dec 12, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Dec 4, 2023

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2fd444) 83.78% compared to head (04b2d8e) 83.78%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6745   +/-   ##
=======================================
  Coverage   83.78%   83.78%           
=======================================
  Files         363      365    +2     
  Lines       21235    21293   +58     
  Branches      948      948           
=======================================
+ Hits        17791    17841   +50     
- Misses       3150     3158    +8     
  Partials      294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafeda dafeda self-assigned this Dec 4, 2023
@dafeda dafeda force-pushed the benchmark branch 3 times, most recently from e88ac6f to 152e256 Compare December 8, 2023 13:08
@dafeda dafeda marked this pull request as ready for review December 8, 2023 13:15
@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Dec 8, 2023
@kvashchuka
Copy link
Contributor

Really cool! Is this the correct address for the github page with benchmark results https://equinor.github.io/ert/? For some reason the page is blank, maybe I am doing something wrong?🧐

@dafeda
Copy link
Contributor Author

dafeda commented Dec 11, 2023

Really cool! Is this the correct address for the github page with benchmark results https://equinor.github.io/ert/? For some reason the page is blank, maybe I am doing something wrong?🧐

The GitHub action I'm using pushes automatically to the gh-pages branch of ert every time someone commits to main.
It pushes to the file data.js in the folder /dev/bench so the correct url is https://equinor.github.io/ert/dev/bench/

@dafeda dafeda changed the title Benchmark Add GitHub workflow for benchmarking Dec 11, 2023
@frode-aarstad
Copy link
Contributor

I like it. How could we make sure people know about this? Add a link to github starting page, mention it in the README ...

@dafeda
Copy link
Contributor Author

dafeda commented Dec 11, 2023

I like it. How could we make sure people know about this? Add a link to github starting page, mention it in the README ...

Perhaps we could show it on the screen in the office?

@dafeda dafeda merged commit 050d02a into main Dec 12, 2023
45 checks passed
@dafeda dafeda deleted the benchmark branch December 12, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants