Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark update-step #6733

Closed
wants to merge 2 commits into from
Closed

Benchmark update-step #6733

wants to merge 2 commits into from

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Dec 1, 2023

Issue
Resolves #6473

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda self-assigned this Dec 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2fd444) 83.78% compared to head (72c99b8) 83.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6733      +/-   ##
==========================================
+ Coverage   83.78%   83.79%   +0.01%     
==========================================
  Files         363      363              
  Lines       21235    21235              
  Branches      948      948              
==========================================
+ Hits        17791    17794       +3     
+ Misses       3150     3147       -3     
  Partials      294      294              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafeda dafeda force-pushed the benchmark branch 2 times, most recently from cffabbd to 5162a21 Compare December 1, 2023 08:05
@dafeda dafeda changed the title Commitin Benchmark update-step Dec 1, 2023
@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Dec 1, 2023
@dafeda dafeda force-pushed the benchmark branch 8 times, most recently from 128601b to e88ac6f Compare December 8, 2023 12:53
@dafeda dafeda closed this Dec 12, 2023
@dafeda dafeda deleted the benchmark branch December 12, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Benchmark the update-step
2 participants