Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on gui tests for mac #6095

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Turn on gui tests for mac #6095

merged 1 commit into from
Sep 19, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 18, 2023

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda self-assigned this Sep 18, 2023
@dafeda dafeda changed the title Test only Python 3.11 for mac Turn on gui tests for mac Sep 18, 2023
@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Sep 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #6095 (633385b) into main (1c6e2b8) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6095      +/-   ##
==========================================
- Coverage   82.65%   82.64%   -0.02%     
==========================================
  Files         349      349              
  Lines       21494    21494              
  Branches      813      813              
==========================================
- Hits        17766    17763       -3     
- Misses       3435     3438       +3     
  Partials      293      293              

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda dafeda force-pushed the mac_tests branch 2 times, most recently from 3b5b6ce to 94faebe Compare September 18, 2023 11:57
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thing is, we need to build with all versions of python for mac. If we don't, then some down stream workflows will stop working because of lacking wheels.

@dafeda
Copy link
Contributor Author

dafeda commented Sep 18, 2023

Thing is, we need to build with all versions of python for mac. If we don't, then some down stream workflows will stop working because of lacking wheels.

I see, was not aware.
Is it OK if I just test using Python 3.10 to save time you think?

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dafeda dafeda force-pushed the mac_tests branch 2 times, most recently from cd9c6eb to 1ab496c Compare September 18, 2023 13:17
Only test Python 3.10 to save time.

Co-authored by: Eivind <[email protected]>
@dafeda dafeda merged commit d1ae20d into equinor:main Sep 19, 2023
76 of 78 checks passed
@dafeda dafeda deleted the mac_tests branch February 3, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants