-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on gui tests for mac #6095
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6095 +/- ##
==========================================
- Coverage 82.65% 82.64% -0.02%
==========================================
Files 349 349
Lines 21494 21494
Branches 813 813
==========================================
- Hits 17766 17763 -3
- Misses 3435 3438 +3
Partials 293 293 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3b5b6ce
to
94faebe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thing is, we need to build with all versions of python for mac. If we don't, then some down stream workflows will stop working because of lacking wheels.
I see, was not aware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
cd9c6eb
to
1ab496c
Compare
Only test Python 3.10 to save time. Co-authored by: Eivind <[email protected]>
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist