Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python 3.10 on run-ert-test-data for macOS #6126

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Sep 20, 2023

Relates to #update gui tests

Use python version 3.10 for macOS.

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@andreas-el andreas-el requested a review from dafeda September 20, 2023 12:32
@andreas-el andreas-el added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Sep 20, 2023
@andreas-el andreas-el changed the title Use python 3.10 on run-ert-test-data for macos Use python 3.10 on run-ert-test-data for macOS Sep 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #6126 (a2f5f67) into main (7b6b10b) will increase coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6126      +/-   ##
==========================================
+ Coverage   82.42%   82.44%   +0.01%     
==========================================
  Files         350      350              
  Lines       21449    21450       +1     
  Branches      834      839       +5     
==========================================
+ Hits        17680    17684       +4     
+ Misses       3471     3468       -3     
  Partials      298      298              

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andreas-el andreas-el force-pushed the default_to_310_python_on_mac branch 2 times, most recently from 83202e8 to a2f5f67 Compare September 22, 2023 07:34
@andreas-el andreas-el force-pushed the default_to_310_python_on_mac branch from a2f5f67 to 40e28ab Compare September 22, 2023 08:07
@andreas-el andreas-el merged commit 9d7d167 into equinor:main Sep 22, 2023
39 checks passed
@andreas-el andreas-el deleted the default_to_310_python_on_mac branch September 22, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants