Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-equinix to v2.2.0 #113

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

github-actions[bot]
Copy link

This PR was generated via $ upgrade-provider equinix/pulumi-equinix --kind=all --target-bridge-version=latest --pr-assign=ocobles.


  • Upgrading terraform-provider-equinix from 2.0.1 to 2.2.0.
  • Upgrading pulumi-terraform-bridge from v3.86.0 to v3.87.0.
  • Upgrading pulumi-terraform-bridge/pf from v0.39.0 to v0.40.0.

@displague
Copy link
Member

the generated commits and PR description would benefit from conventional commit formatting

@displague
Copy link
Member

CI can't trigger additional CI. Tests won't run on these automated branches.

@ocobles ocobles marked this pull request as draft July 18, 2024 10:14
Oscar Cobles added 4 commits July 18, 2024 13:46
Signed-off-by: Oscar Cobles <[email protected]>
Signed-off-by: Oscar Cobles <[email protected]>
Copy link
Author

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 4 breaking changes:

Types

  • "equinix:networkedge/getDeviceClusterDetailNode0VendorConfiguration:getDeviceClusterDetailNode0VendorConfiguration": required:
    • 🟢 "panoramaAuthKey" property has changed to Required
    • 🟢 "panoramaIpAddress" property has changed to Required
  • "equinix:networkedge/getDeviceClusterDetailNode1VendorConfiguration:getDeviceClusterDetailNode1VendorConfiguration": required:
    • 🟢 "panoramaAuthKey" property has changed to Required
    • 🟢 "panoramaIpAddress" property has changed to Required
      No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@ocobles
Copy link
Contributor

ocobles commented Jul 18, 2024

CI can't trigger additional CI

@displague this can be fixed by using a PAT of an Equinix "bot" user

@ocobles ocobles marked this pull request as ready for review July 18, 2024 14:17
@ctreatma
Copy link
Contributor

CI can't trigger additional CI

@displague this can be fixed by using a PAT of an Equinix "bot" user

Another option would be to use a GitHub App token to talk to the API, although that requires getting an organization owner to create a new GitHub App.

@ocobles ocobles merged commit e92f738 into main Jul 22, 2024
14 checks passed
@ocobles ocobles deleted the upgrade-terraform-provider-equinix-to-v2.2.0-76631427 branch July 22, 2024 15:25
@ctreatma
Copy link
Contributor

In other repos we accepted the limitation on GHA tokens by duplicating the test steps in the automated upgrade workflows, and that might be the quickest approach for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants