Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update upgrade-provider generated commits to use conventional commit formatting #114

Closed
ocobles opened this issue Jul 18, 2024 · 3 comments
Closed

update upgrade-provider generated commits to use conventional commit formatting #114

ocobles opened this issue Jul 18, 2024 · 3 comments

Comments

@ocobles
Copy link
Contributor

ocobles commented Jul 18, 2024 

          the generated commits and PR description would benefit from conventional commit formatting

Originally posted by @displague in #113 (comment)
@ocobles ocobles changed the title the generated commits and PR description would benefit from conventional commit formatting update upgrade-provider generated commits to use conventional commit formatting Jul 18, 2024
@ocobles
Copy link
Contributor Author

ocobles commented Jul 18, 2024

Although it's not documented, I found a flag to add a prefix to the commit title: https://github.com/pulumi/upgrade-provider/blob/b625b8f79e1e57d625bbc31aadaefc380a917c16/main.go#L256

@ocobles
Copy link
Contributor Author

ocobles commented Jul 18, 2024

We can validate/enforce the title format with something like https://github.com/equinix/terraform-provider-equinix/blob/main/.github/workflows/validate_pr.yml This will help in automated releases

@displague displague mentioned this issue Jul 23, 2024
Merged
ctreatma added a commit that referenced this issue Jul 23, 2024
@ctreatma
chore(ci): add feature prefix to automated upgrade PRs (#116)
b744749 
This adds the `pr-title-prefix` argument to the upgrade steps in the
upgrade-bridge and upgrade-provider workflows. In the case where we were
using the official Pulumi upgrade action, this upgrades that action to
the latest version, v0.0.12. That version introduced the
`pr-title-prefix` argument and matches the base code of our custom
action.

Part of #114
@ocobles
Copy link
Contributor Author

ocobles commented Aug 1, 2024

fixed in #116

@ocobles ocobles closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ocobles