MUI: Compat with React 19 types #619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eps1lon
commented
Mar 19, 2024
| @@ -41,13 +41,13 @@ describe('utils/getDisplayName.js', () => { | |||
| )); | |||
| NamedForwardRefComponent.displayName = 'Div'; | |||
|
|
|||
| const AnonymousMemoComponent = React.memo((props, ref) => <div {...props} ref={ref} />); | |||
| const AnonymousMemoComponent = React.memo((props) => <div {...props} />); | |||
There was a problem hiding this comment.
Was not caught previously because types assumed the ref argument is actually the legacy context. Now that we removed legacy context, this bug is surface.
eps1lon
commented
Mar 19, 2024
| @@ -1001,13 +1001,17 @@ function GlobalVariantForm({ | |||
| onRemove: (token: string) => void; | |||
| }) { | |||
| const [selectedVariant, setSelectedVariant] = React.useState<VariantProp>('solid'); | |||
| const [states, setStates] = React.useReducer< | |||
| StateReducer<{ hover: boolean; active: boolean; disabled: boolean }> | |||
|
Emotion is informed, Next 13 no longer maintained, |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will include necessary changes to be compatible with 19. Type-checking may still fail due to 3rd party libraries not being compatible.
Closes eps1lon/DefinitelyTyped#19
Changes
Mostly
ReactElement->ReactElement<any>changes. We have so many here, since MUI heavily relies on element introspection so the amount of breaking changes is expected. I'll write an opt-in codemod that would cover most of it.There was one with regards to
useReducerwhich is also intended. In this case the new typing required isn't stricly better though.Unresolved Issues
@react-spring/webuses the removed, global JSX namespace so it doesn't know about built-in components anymore. This lead to issues with e.g.<animated.div children={null} />erroring becauseproperty 'children' does not exist on type ....Fixed by migration
@react-spring/webto no longer use deprecated namespaces.@emotion/[email protected]references deprecated global JSX namespace[email protected]references deprecated global JSX namespaceTypechecking performance
No significant change as far as I can tell.
React 19 types coldstart: `pnpm tsc -p tsconfig.json --extendedDiagnostics`
React 18 types coldstart: `pnpm tsc -p tsconfig.json --extendedDiagnostics`