Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Compatibility with React 19 types #42032

Closed
3 tasks done
Tracked by #42381
eps1lon opened this issue Apr 26, 2024 · 3 comments
Closed
3 tasks done
Tracked by #42381

[core] Compatibility with React 19 types #42032

eps1lon opened this issue Apr 26, 2024 · 3 comments
Assignees
Labels
core Infrastructure work going on behind the scenes React 19 support PRs required to support React 19 typescript

Comments

@eps1lon
Copy link
Member

eps1lon commented Apr 26, 2024

Summary

To be compatible with React 19, types must be compatible. Many changes are codemoddable with npx types-react-codemod@latest but a lot of changes need to be done manually because your relied on element.props being typed as any. There are also some 3rd party libraries that need to be be compatible first.

A full overview of the necessary changes can be found in eps1lon#619. You can also check out https://github.com/users/eps1lon/projects/3/views/9 to get an overview what other apps/libraries need to do for migration.

Tasks

Search keywords: types react 19

@eps1lon eps1lon added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 26, 2024
@zannager zannager added the package: material-ui Specific to @mui/material label Apr 29, 2024
@mnajdova
Copy link
Member

mnajdova commented May 14, 2024

@DiegoAndai one more thing to be handled for React 19 compatibility. Thanks @eps1lon for the instructions :)

@DiegoAndai DiegoAndai removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 23, 2024
@DiegoAndai DiegoAndai assigned DiegoAndai and unassigned mnajdova May 23, 2024
@DiegoAndai DiegoAndai changed the title Compatibility with React 19 types [core] Compatibility with React 19 types May 24, 2024
@DiegoAndai DiegoAndai added core Infrastructure work going on behind the scenes and removed package: material-ui Specific to @mui/material labels May 24, 2024
@oliviertassinari oliviertassinari added the React 19 support PRs required to support React 19 label Sep 5, 2024
@DiegoAndai
Copy link
Member

@types/react and @types/react-dom bumped in #44672

Copy link

github-actions bot commented Dec 9, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes React 19 support PRs required to support React 19 typescript
Projects
None yet
Development

No branches or pull requests

5 participants