Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bootstrap 5 3 3 #859

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Upgrade bootstrap 5 3 3 #859

merged 7 commits into from
Dec 5, 2024

Conversation

JoeArmani
Copy link
Collaborator

Related:
episphere/connect#1167
•Quest 2.0 ConnectApp integration

PR includes:
•Update Bootstrap version to 5.3.3 & resolve breaking changes.
•Update Quest loading to support Quest and Quest 2.0+ during migration.
•Marked Deprecated Quest integrations. We'll retain these for compatibility during migration.

Note on Quest 2 survey integration (questionnaire.js): These are activated based on the timestamp in Firestore -> appSettings -> connectApp doc, so we can update them dynamically as we migrate surveys.

@JoeArmani JoeArmani requested review from a team, anthonypetersen and jhflorey and removed request for a team November 26, 2024 17:44
@JoeArmani JoeArmani linked an issue Nov 26, 2024 that may be closed by this pull request
@JoeArmani JoeArmani requested review from we-ai and removed request for jhflorey November 26, 2024 18:20
Copy link
Collaborator

@we-ai we-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Thanks for this huge PR: migrating Bootstrap to latest version, Quest2 integration, code cleanups, etc.
I don't see anything that breaks code running. My suggestions/comments just reflect my personal preferences.

css/style.css Outdated Show resolved Hide resolved
css/style.css Outdated Show resolved Hide resolved
js/pages/footer.js Outdated Show resolved Hide resolved
js/pages/questionnaire.js Outdated Show resolved Hide resolved
js/pages/support.js Outdated Show resolved Hide resolved
js/shared.js Outdated Show resolved Hide resolved
js/shared.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Copy link
Contributor

@anthonypetersen anthonypetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

Copy link
Collaborator

@we-ai we-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks for cleaning up and improving quality of code not directly related to tasks.
Commented on minor things.

app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
js/event.js Outdated Show resolved Hide resolved
js/shared.js Outdated Show resolved Hide resolved
@JoeArmani JoeArmani merged commit e125ecd into dev Dec 5, 2024
@JoeArmani JoeArmani deleted the upgrade-bootstrap-5-3-3 branch December 5, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PWA Bootstrap 5 upgrade
3 participants