-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bootstrap 5 3 3 #859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Thanks for this huge PR: migrating Bootstrap to latest version, Quest2 integration, code cleanups, etc.
I don't see anything that breaks code running. My suggestions/comments just reflect my personal preferences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for cleaning up and improving quality of code not directly related to tasks.
Commented on minor things.
Related:
•episphere/connect#1167
•Quest 2.0 ConnectApp integration
PR includes:
•Update Bootstrap version to 5.3.3 & resolve breaking changes.
•Update Quest loading to support Quest and Quest 2.0+ during migration.
•Marked Deprecated Quest integrations. We'll retain these for compatibility during migration.
Note on Quest 2 survey integration (questionnaire.js): These are activated based on the timestamp in Firestore -> appSettings -> connectApp doc, so we can update them dynamically as we migrate surveys.