Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #45

Merged
merged 5 commits into from
Oct 25, 2024
Merged

CI improvements #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fbd92cd
Rename `build` to `wasm-build` in CI
fjarri Oct 24, 2024
6d35218
Rename `coveralls` to `test-and-coverage` in CI
fjarri Oct 24, 2024
c5ed787
Ensure `--all-features` are enabled for tests
fjarri Oct 24, 2024
f5d19f4
Remove `test` CI job, since it's the same as `test-and-coverage`
fjarri Oct 24, 2024
fcd6776
Add a test job that uses a fixed Rust version and Cargo.lock
fjarri Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ env:
RUSTFLAGS: "-Dwarnings"

jobs:
build:
wasm-build:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: we should mention in the README that the crate is nostd, perhaps in the "goals" section.

runs-on: ubuntu-latest
strategy:
matrix:
Expand All @@ -30,7 +30,7 @@ jobs:
- run: cargo build --target ${{ matrix.target }} --no-default-features
- run: cargo build --target ${{ matrix.target }}

coveralls:
test-and-coverage:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -43,20 +43,22 @@ jobs:
- name: Install cargo-llvm-cov
uses: taiki-e/install-action@cargo-llvm-cov
- name: Generate code coverage
run: cargo llvm-cov --workspace --lcov --output-path lcov.info
run: cargo llvm-cov --workspace --all-features --lcov --output-path lcov.info
- name: Upload coverage to Coveralls
uses: coverallsapp/github-action@v2
with:
files: lcov.info
fail_on_error: true

tests:
# This is supposed to factor out possible bugs introduced by Rust compiler changes
# and dependency changes, making the results more reproducible.
stable-test:
runs-on: ubuntu-latest
strategy:
matrix:
include:
- target: x86_64-unknown-linux-gnu
rust: stable
rust: 1.81.0 # MSRV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was an "organization-wide" way of defining this, so that when we change it, it applies to all crates.

steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@v1
Expand All @@ -66,7 +68,7 @@ jobs:
profile: minimal
override: true
- run: ${{ matrix.deps }}
- run: cargo test --target ${{ matrix.target }}
- run: cargo test --workspace --locked --all-features --target ${{ matrix.target }}

clippy:
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/target
Cargo.lock
*.sublime-project
*.sublime-workspace
Loading
Loading