Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #45

Merged
merged 5 commits into from
Oct 25, 2024
Merged

CI improvements #45

merged 5 commits into from
Oct 25, 2024

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Oct 24, 2024

Note: the docs for cargo test say about --locked: "Cargo will exit with an error when either of the following scenarios arises: ... Cargo attempted to change the lock file due to a different dependency resolution." I think it's not going to error out if some dependency bumps the patch version, but I'm not sure.

@dvdplm if you think that the stable test is not really needed, that can be reverted. I'm not sure myself.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11505804412

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.243%

Totals Coverage Status
Change from base Build 11505585913: 0.0%
Covered Lines: 1204
Relevant Lines: 1690

💛 - Coveralls

@fjarri fjarri requested a review from dvdplm October 24, 2024 19:17
@@ -12,7 +12,7 @@ env:
RUSTFLAGS: "-Dwarnings"

jobs:
build:
wasm-build:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: we should mention in the README that the crate is nostd, perhaps in the "goals" section.

runs-on: ubuntu-latest
strategy:
matrix:
include:
- target: x86_64-unknown-linux-gnu
rust: stable
rust: 1.81.0 # MSRV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was an "organization-wide" way of defining this, so that when we change it, it applies to all crates.

@dvdplm
Copy link
Contributor

dvdplm commented Oct 25, 2024

As for the stable test: I have a (weak) preference for omitting the --locked because that means that the tests will indeed fail when deps go out of sync. I'd rather be alerted early to such things than tackling them all at once. That said, almost nobody agrees with me so I'm likely wrong!

Let's go with what the docs say for now and if it ever becomes annoying we can re-assess?

@dvdplm dvdplm merged commit 6aee9bf into entropyxyz:master Oct 25, 2024
8 checks passed
@fjarri fjarri deleted the stable-test branch October 25, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "stable dependencies test" CI task
3 participants