-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI improvements #45
CI improvements #45
Conversation
Just so that we don't miss it if we do add some features.
Pull Request Test Coverage Report for Build 11505804412Details
💛 - Coveralls |
@@ -12,7 +12,7 @@ env: | |||
RUSTFLAGS: "-Dwarnings" | |||
|
|||
jobs: | |||
build: | |||
wasm-build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: we should mention in the README
that the crate is nostd
, perhaps in the "goals" section.
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
include: | ||
- target: x86_64-unknown-linux-gnu | ||
rust: stable | ||
rust: 1.81.0 # MSRV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish there was an "organization-wide" way of defining this, so that when we change it, it applies to all crates.
As for the stable test: I have a (weak) preference for omitting the Let's go with what the docs say for now and if it ever becomes annoying we can re-assess? |
Note: the docs for
cargo test
say about--locked
: "Cargo will exit with an error when either of the following scenarios arises: ... Cargo attempted to change the lock file due to a different dependency resolution." I think it's not going to error out if some dependency bumps the patch version, but I'm not sure.@dvdplm if you think that the stable test is not really needed, that can be reverted. I'm not sure myself.