-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dic2owl
to new annotated ontology schema
#52
Conversation
3e14606
to
37b5bb0
Compare
a47d0d5
to
a5185b9
Compare
@jesper-friis What do you say to this being merged? Before doing so I will up the |
Agree, it is time to merge. Just one thing, the dic2owl cli should actually call its main function when you call it as a script, be made executable (incl. shabang at top) and probably also added as a distributed script in setup.py |
It should already do this - I made a mistake when adding the extra authors in the I will create a new issue from this comment however, which will cover adding other CI checks for |
- Added workaround for EMMO-python.
Update doc-strings and type information.
Fixed the problem with adding top-level class in generated ontology. Also added annotations.
Started on adding values.
Now the generation works - just two special cases left to handle + cleanup Also corrected some typos in cif-ddl.ttl. Added metadata to generated ontology.
- Run pre-commit. - Add some typing. - Make bandit check skip `urlretrieve` line, since `file://` will never be used as input. - Satisfy pylint + mypy. - Add pylint configuration in setup.cfg. - Add mypy cache folder to .gitignore. - Ensure `safety` checks the installed dependencies. - Exchange `flake8` with `pylint` in pre-commit - updating files accordingly. - Use `pyproject.toml` instead of `setup.cfg`. - Set line-length to 79 (80) in `black` (`pylint`) tools. Remove old ontology generation file. Update requirements to be more lenient. Minimize CI runs: Only run `dic2owl` CI if a file change under `dic2owl/` and only run the CI for `push`. Update authors. Mention CLI in doc-string for setup.py. Remove `__main__` section in dic2owl.py.
Ensure `dic2owl` is installable through CI.
Fixes #56.
Update the
dic2owl
package and automatic ontology generation to the new annotated ontology schema introduced in #50.