Import from web instead of local files #27
Conversation
dic2owl/dic2owl/generate_cif.py
Outdated
| self.cd = CifDic(dicfile, do_dREL=False) | ||
| self.cif_top = ontology_dir() / cif_top | ||
| if not cif_top: | ||
| self.cif_top = f'{release_site}/{__version__}/cif_top.ttl' |
There was a problem hiding this comment.
Ah, but this expects that the version of the dic2owl package is the same as the latest overall version of the ontology.
I think we should add some automatic extraction of the latest ontology release version instead. Perhaps solely use GH releases for this and retrieve the latest? Or perhaps go through the git tags and get the latest from there, once we've decided on the proper versioning and tagging scheme?
There was a problem hiding this comment.
Good point. Should we then define top_version in init.py to have the related version expressed in a single place?
There was a problem hiding this comment.
I think __ontology_version__ would be better? This would then refer to the version of cif.ttl as well as the repository as a whole - i.e., git tags and GH releases.
I'll try to flesh out this description in #28 through a README edit :)
|
The aim or this PR was to include an explicit url to cif_top in owl:imports of the generated cif_core.ttl. However, it seems that even though that we give an explicit url to cif_top when loading it in generate_cif.py, it is the ontology IRI http://emmo.info/domain-crystallography/cif_top that gets serialised. I think we could close this PR for now and instead concentrate on how we want to publish the ontologies. |
|
The aim or this PR was to include an explicit url to cif_top in owl:imports of the generated cif_core.ttl. However, it seems that even though that we give an explicit url to cif_top when loading it in generate_cif.py, it is the ontology IRI http://emmo.info/domain-crystallography/cif_top that gets serialised. I think we could skip this PR for now and instead concentrate on how we want to publish the ontologies. |
CasperWA
force-pushed
the
import-explicit-version-of-cif_top
branch
from
bcf5c5d to
4ec4ed6
Compare
CasperWA
force-pushed
the
import-explicit-version-of-cif_top
branch
from
c95fa8f to
e802a0f
Compare
|
According to the comment above I'll close this PR. Since the central |
To reduce issues with import errors