Round widget coordinates to even multiple of 1/32 #5517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5517-emilkround-coordinates |
emilk
changed the title
emilk
force-pushed
the
emilk/round-coordinates
branch
from
0dcf5a0 to
33731f6
Compare
emilk
force-pushed
the
emilk/round-coordinates
branch
from
ebf73e4 to
56f7885
Compare
emilk
added a commit
that referenced
this pull request
Dec 26, 2024
* Merge this first: #5517 This aligns all rectangles and (horizontal or vertical) line segments to the physical pixel grid in the `epaint::Tessellator`, making these shapes appear crisp everywhere. * Closes #5164 * Closes #3667 This undoes a lot of the explicit, egui-side aligning added in: * #4943 The new approach has several benefits over the old one: * It is done automatically by epaint, so it is applied to everything (no longer opt-in) * It is applied after any layer transforms (so it always works) * It makes line segments crisper on high-DPI screens * All filled rectangles now has sides that end on pixel boundaries
This was referenced Dec 27, 2024
|
Nice! Gave it a test in egui_flex, it works flawlessly and allows me to get rid of my custom rounding code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help prevent rounding errors in layout code.
@lucasmerlin you may wanna test this with
egui_flex