-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all lines and rectangles crisp #5518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
changed the title
Fix bug in Painter::with_layer_id
Make all lines and rectangles crisp
Dec 26, 2024
Preview available at https://egui-pr-preview.github.io/pr/5518-emilkround-shapes-to-pixels |
emilk
added
egui
epaint
do not merge
do-not-merge
Do not merge yet, but you can still review it
and removed
do not merge
labels
Dec 26, 2024
emilk
force-pushed
the
emilk/round-shapes-to-pixels
branch
from
December 26, 2024 19:57
23372b7
to
9a22b0c
Compare
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns all rectangles and (horizontal or vertical) line segments to the physical pixel grid in the
epaint::Tessellator
, making these shapes appear crisp everywhere.This undoes a lot of the explicit, egui-side aligning added in:
The new approach has several benefits over the old one: