Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modals: Add UiKind::Modal, and consume escape-key properly #5414

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

abey79
Copy link
Collaborator

@abey79 abey79 commented Nov 29, 2024

Small fixes/improvements to Modal

@abey79 abey79 added egui feature New feature or request labels Nov 29, 2024
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5414-antoine/modal-improvements
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@abey79 abey79 marked this pull request as ready for review December 3, 2024 10:42
abey79 added a commit to rerun-io/rerun that referenced this pull request Dec 3, 2024
TODO: update egui refs when emilk/egui#5414 lands
@emilk emilk requested a review from lucasmerlin December 3, 2024 10:44
@emilk emilk changed the title Improve Modal Modals: Add UiKind::Modal, and consume escape-key properly Dec 3, 2024
@emilk emilk merged commit 3411aba into master Dec 3, 2024
47 checks passed
@emilk emilk deleted the antoine/modal-improvements branch December 3, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a UiKind::Modal for egui::Modal's Area
2 participants