Use egui::Modal to implement our modal dialogs
#8288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
abey79
added
ui
# Conflicts: # Cargo.lock # Cargo.toml
teh-cmc
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Am I somehow magically looking at LFS-backed data, or was this committed directly to the repo?
There was a problem hiding this comment.
TL;DR: yes.
GH is extremely bad at displaying that stuff. The best I could do is to go to the relevant branch, navigate to the file in question, and notice the tiny mention top left:
Also, CI allegedly checks for that.
There was a problem hiding this comment.
TIL you can navigate to that file by using the … menu in the diff view and pick "View file".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
ModalandMemory::set_modal_layeremilk/egui#5358UiKind::Modal, and consume escape-key properly emilk/egui#5414What
Our modal used to be implemented using a wrapper which used
egui::Window. The guts of that wrapper are now reimplemented based onegui::Modal. That wrapper is now namedModalWrapper. This does not affect "user" code, which can still use the existingModalHandler.This PR does not affect the styling of the modals. The only difference is modal are now centred on the window (that
egui::Modal's default behaviour). Previously they were slightly offset towards the top of the window.TODO
UiKind::Modal, and consume escape-key properly emilk/egui#5414 is merged