Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on Android #3676

Closed
wants to merge 1 commit into from
Closed

Fix crash on Android #3676

wants to merge 1 commit into from

Conversation

emilk
Copy link
Owner

@emilk emilk commented Dec 4, 2023

@emilk emilk added bug Something is broken eframe Relates to epi and eframe labels Dec 4, 2023
@emilk emilk added the android label Dec 4, 2023
@m-hugo
Copy link

m-hugo commented Dec 4, 2023

exactly the same .cargo/git/checkouts/egui-5e4507fa4153be06/a474724/crates/eframe/src/native/wgpu_integration.rs:399:69: called Option::unwrap() on a None value

@m-hugo
Copy link

m-hugo commented Dec 4, 2023

if you want to add some logging, just do some println!'s

@emilk
Copy link
Owner Author

emilk commented Dec 4, 2023

Oh right, the main viewport is removed…

I don't own an android device, so it would be better if someone else worked on this.

@m-hugo
Copy link

m-hugo commented Dec 4, 2023

hey @rib, can you update rust-android-examples/agdk-eframe to egui v0.24, it doesn't even cause compile errors (there's just a tiny window resuming problem to fix (that might involve reading a +5,087 −1,273 merge request (plus a bit of file shuffling that happened since it was merged)))

@rib
Copy link
Contributor

rib commented Dec 5, 2023

yeah I've been meaning to do an update of all those examples to update egui + winit so can hopefully look at that soon

@emilk
Copy link
Owner Author

emilk commented Dec 8, 2023

Converting to Draft - If somebody is interested in fixing Android, just fork this and make a new PR

@emilk emilk marked this pull request as draft December 8, 2023 12:49
@emilk emilk closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something is broken eframe Relates to epi and eframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eframe's Event::Resumed on android panics since #3172
3 participants