-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eframe's Event::Resumed on android panics since #3172 #3674
Labels
bug
Something is broken
Comments
almost the same with glow but with a black screen and while I got a panic |
Closed
Please see if #3676 helps |
ghost
mentioned this issue
Dec 5, 2023
Closed
emilk
pushed a commit
that referenced
this issue
Jan 22, 2024
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to add commits to your PR. * Remember to run `cargo fmt` and `cargo cranky`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> Added Viewport reinitialization and Window recreation for Android on resume event. Closes <#3674>. https://github.com/emilk/egui/assets/95014675/7bc51ea5-3f63-4422-b5a0-ce8291612982
follow-up at #3861 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hiding and resuming any eframe app on android since #3172 causes it to crash, logging (on master)
thread panicked at .cargo/git/checkouts/egui-5e4507fa4153be06/84a6d6f/crates/eframe/src/native/wgpu_integration.rs:392:54: no entry found for key
egui/crates/eframe/src/native/wgpu_integration.rs
Line 392 in 84a6d6f
the offending line
is running.shared.borrow().viewports[&ViewportId::ROOT]
the commit after #3172 logs the same line but in eframe/src/native/run.rs
the commit before works fine
digging in #3172's commits, it was broken as early as 7caa042
.get(&ViewportId::ROOT)
:called Option::unwrap() on a None value
Expected behavior
get back to the app normally like before #3172
Smartphone
The text was updated successfully, but these errors were encountered: