Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid: Row/column colors #364
Grid: Row/column colors #364
Changes from 11 commits
272476b
7ead713
35cb9d3
456fb79
b9480c4
44eeb57
05341a1
5fb4991
79a1a53
d68086c
b8b7c42
d6c6fbe
b82843c
4a76e34
43778ec
64664c3
9756d07
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do_paint
checks ifrow == 0
which it never is here. Better to just callpaint_row
here to avoid confusion:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paint_row
only paints a single row. Thepaint
method iterates through all the row pickers and paints for every case that fits. If you prefer, I can breakpaint
intopaint_rows
andpaint_cols
, but I personally feel that it's okay to call a singlepaint
method that handles everything.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can just add to
color_spec.row_pickers
directly. Same forstriped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that if someone subsequently calls
header_row(false)
, it's not trivial to figure out how to remove the added row coloration from therow_pickers
, and also kinda weird to be comparing closures/fn pointers/whatever. Would appreciate thoughts.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps header_row() can be a method with no arguments that, when called, irreversibly sets the header coloration, and same for stripes?