-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid: Row/column colors #364
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
272476b
Feat grid: initial impl of header rows
skairunner 7ead713
Refactor grid: Add GuiColor, ColorSpec.
skairunner 35cb9d3
Feat: Add by-column colors
skairunner 456fb79
Feat grid: Cell support
skairunner b9480c4
Merge branch 'master' into sky/headers
skairunner 44eeb57
Fix: Incorporate PR comments.
skairunner 05341a1
Update egui/src/grid.rs
skairunner 5fb4991
Update egui/src/grid.rs
skairunner 79a1a53
Fix: Remove unused import
skairunner d68086c
Merge branch 'master' into sky/basic-tables
skairunner b8b7c42
More clippy
skairunner d6c6fbe
Fix: Renamings and other superficial changes
skairunner b82843c
Fix: Remove `start_row`. Make `paint_row`/`paint_col` private
skairunner 4a76e34
Fix: Running total of column widths
skairunner 43778ec
clippy
skairunner 64664c3
Merge branch 'master' into sky/headers
skairunner 9756d07
Box ColorPickerFn
skairunner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can just add to
color_spec.row_pickers
directly. Same forstriped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that if someone subsequently calls
header_row(false)
, it's not trivial to figure out how to remove the added row coloration from therow_pickers
, and also kinda weird to be comparing closures/fn pointers/whatever. Would appreciate thoughts.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps header_row() can be a method with no arguments that, when called, irreversibly sets the header coloration, and same for stripes?