Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search input component to glimmer #814

Merged
merged 4 commits into from
Nov 18, 2022
Merged

Update search input component to glimmer #814

merged 4 commits into from
Nov 18, 2022

Commits on Jul 24, 2022

  1. search-input: update to glimmer

    Let's update the SearchInput component to extend glimmer/component
    instead of ember/component. Glimmer components offer a bunch of various
    advantages over classic components and are the direction that ember is
    heading in general.
    
    While we're here, let's also re-enable the eslint rules for which the
    SearchInput component had the only violations.
    geneukum committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    5c89e34 View commit details
    Browse the repository at this point in the history
  2. tests: search-input: use render helper

    Ember's this.render method and @ember/test-helpers's render method are
    equivalent, but using @ember/test-helpers' render method is the
    recommended approach. As such, let's go ahead and switch this over.
    
    While we're here, let's re-enable this eslint rule as we no longer have
    any violations.
    geneukum committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    f9f1e37 View commit details
    Browse the repository at this point in the history
  3. tests: search-input: prefer angle bracket syntax

    Let's prefer angle bracket syntax to curly syntax when invoking the
    SearchInput component in our integration tests.
    geneukum committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    291668e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. Configuration menu
    Copy the full SHA
    577eee3 View commit details
    Browse the repository at this point in the history