Update search input component to glimmer #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's update the SearchInput component to extend glimmer/component instead of ember/component. Glimmer components offer a bunch of various advantages over classic components and are the direction that ember is heading in general. While we're here, let's also re-enable the eslint rules for which the SearchInput component had the only violations.
Ember's this.render method and @ember/test-helpers's render method are equivalent, but using @ember/test-helpers' render method is the recommended approach. As such, let's go ahead and switch this over. While we're here, let's re-enable this eslint rule as we no longer have any violations.
Let's prefer angle bracket syntax to curly syntax when invoking the SearchInput component in our integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's update the SearchInput component to extend glimmer/component instead of ember/component. Glimmer components offer a bunch of various advantages over classic components and are the direction that ember is
heading in general.
While we're here, let's prefer single quotes to double quotes throughout our template file, cleanup some test deprecations, and re-enable all of the ESLint rules for which this component was the only violator.
This should resolve the app/components/search-input.js section of #805.