Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for treemacs #4

Closed

Conversation

Alexander-Miller
Copy link

Updated treemacs PR, as requested in #2.

tarsius pushed a commit that referenced this pull request Nov 22, 2023
@tarsius
Copy link
Member

tarsius commented Nov 22, 2023

Thanks!

Because I don't use this package, I cannot actually test this, but it looks obviously right, so I am merging it.

(Well, I would have merged, but I also wanted to add #4 to the commit message, and wasn't able to push to your feature branch, so this is now "merged".)

@tarsius tarsius closed this Nov 22, 2023
@Alexander-Miller
Copy link
Author

Turns out the code isn't quire correct - I assumed evil-escape would use the motion-state path because that's what treemacs-state inherits from, but the treemacs code needs to go into the normal state path instead. I'll open a new PR in a few minutes.

It'll also require an up-to-date version of treemacs since I added treemacs to evil-escape-excluded-major-modes a while ago. I can't remember exactly what was incompatible, but now that official support is added I'll remove this part again.

Well, I would have merged, but I also wanted to add #4 to the commit message, and wasn't able to push to your feature branch, so this is now "merged"

Sorry, I could've sworn I had checked the allow edits option. No idea why it's disabled now.

tarsius pushed a commit that referenced this pull request Nov 22, 2023
This fixes [1: f71394b].

1: 2023-11-22 f71394b
   Add support for treemacs (#4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants