Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct treemacs integration. #5

Closed

Conversation

Alexander-Miller
Copy link

Corrected (and tested) treemacs integration, as discussed in #4.

tarsius pushed a commit that referenced this pull request Nov 22, 2023
This fixes [1: f71394b].

1: 2023-11-22 f71394b
   Add support for treemacs (#4)
@tarsius
Copy link
Member

tarsius commented Nov 22, 2023

Thanks.
"Merged" also see below:

@tarsius
Copy link
Member

tarsius commented Nov 22, 2023

Unfortunately this pull-request asks for your master branch to be merged into ours. It is better to use a dedicated feature branch instead, as explained here. It is too late for this pull-request now, but the next time you open a pull-request (in any repository really), then please use a feature branch.

While you did use a feature branch, you did not give them maintainer push rights to it.

This is a canned response; it may not apply 100% in this case.

@tarsius tarsius closed this Nov 22, 2023
@Alexander-Miller
Copy link
Author

While you did use a feature branch, you did not give them maintainer push rights to it.

I open the PR, the box is checked. I come back to it the next day, it's unchecked. You might want to consider creating a new repository, I think this one is cursed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants