-
Notifications
You must be signed in to change notification settings - Fork 187
Pre Release Notes 3.4
Grunthos edited this page Mar 8, 2011
·
41 revisions
Testing so far...
- Tested under 1.6
- Made changes to allow user-based LT dev key
- Retested search and new screens under 1.6
- Tested Under 2.1; got a non-reproducible FC while testing:
E/AndroidRuntime( 228): Caused by: java.lang.IllegalStateException: get field slot from row 0 col -1 failed
- Which is very odd since the call that failed, BookCatalogue.java:543, was a result of getColumnIndex returning -1. Which imples that the SERIES_NAME field was no in the groupCursor...which seem impossible unless the groupCursor was incorrect in some way.
- Best guess is that mViewManager was changed but somehow the groupCursor was old; perhaps out of sync with mBooksAdapter, but both are set in fillData(), so that seems unlikely.
- On the assumption this is what happened (perhaps if a binder operates in a different thread), I have changed BasiCBookListAdapter to be an inner class of ViewManager so that it always has the correct instance of ViewManager available.
- This has resulted in cleaner code...and less instance variables
- Retested under 2.1...
- No crashes. New bugs noted (anthology and loans not deleted when books are deleted)
Time for lots of testing! I don't plan to add much more in the short term...
Issues will be crossed out as they are solved; they will be added here even if not reported elsewhere to help avoid duplication.
All admin functions seem to work fine- (Fixed)
Using keys in the emulator to navigate between fields causes a FC (java.lang.IndexOutOfBoundsException: charAt: -2 < 0). However since I can't replicate this on my phone I suppose it is ok.FWIW, only seems to happen to me on unicode chars. - (Fixed)
Authors/Series: Its too easy to forget to press add and just hit save. It should prompt to add - (Fixed)
Authors/Series: The field doesn't blank when you press add - (Done?)
Authors/Series: There is a small string "title" at the top of the view. Remove this? - (Fixed)
Series: Should be able to have more than 1 of the same series in a book - (Answered)
How does replace thumbnail from other editions work? - (Fixed)
A toast validation alert pops up for invisible fields - (Done)
When a book has multiple authors on the catalogue screen, deleting a book from one author deletes from all authors. This is absolutely the correct behaviour, but I think we need a prompt alerting the user that "You are deleting Trigger by Arthur C Clarke and Michael McDowell". Now confirms all book deletions in Catalogue view (minor fix by EL). - (Done)
The text string when updating fields automatically should be explicit as to which fields will be updated, e.g. Author, series as well as genre, description and thumbnails. - (Fixed)
I get a (correctly caught) null pointer exception when going from into the catalogue view. Line 1398 (BookCatalogue.java - my HEAD). Are those intents still being used? - (Fixed)
Crash when searching if sorted by series - (Fixed)
Crash when searching if sorted by genre - (Fixed)
Reintroduced crash when searching via ISBN and rotatin screen. - (Fixed)
Odd issue when scanning barcodes; it looks like more than one scanner gets started and/or more than one book instance gets added. Needs investigation.Caused by zombie search results being kept on rotate. - (Gone? Can't reproduce) similar bug causes a finished export to restart after screen rotation.
- (Done)
MANDATORY for relase: ensure LibraryThing ToR are enforced -- specifically, no more than 1 request/second (I'd just add a static 'mLastRequest' time and a thread.sleep() call. We only have oNE UI thread request to LT and it needs to be put in BG. - (Fixed)
Doesn't save multiple of the same series (with different numbers)- Could you double check and test. Ensure that I haven't broken anything! - (Done)
LibraryThing people have not got back to me after 3 weeks and a couple of requests. The current rules for the Dev Key say that only 1000 requests/day will be allowed. Most likely, this will be exceeded the first day to the great frustration of users. My suggestion is that we have a library thing setup page where a user can enter their own developer key, along with a link to the page for registering in LibraryThing and for the page requesting a developer key. This seems like not a bad compromise, and may be what they intended since in one post they suggest their users should get dev keys.Now asks user to get a dev key when required. Runs without as well. - (Fixed)
Deleting a book that is the last under an author (or series) results in the author (or series) still being displayed. - Anthology table entries not being deleted when book is deleted. These should probably become 'On Delete Cascade' refs
- loans table entries not being deleted when book is deleted. These should probably become 'On Delete Cascade' refs
- (Fixed)
EditObjectList not closing DB.Added an onDestroy() handler.
The button was being treated as a textfield. Updated edit_book.xml
I have removed this for the time being. If we want to add it in, thats ok too
G: NP. It's fine with me.
The text string when updating fields automatically should be explicit as to which fields will be updated, e.g. Author, series as well as genre, description and thumbnails.
I suspect we may need to make this into an activity with checkboxes for all internet-sourced fields. The search code just grabs everything, but the results should then be filtered based on the user selections and applied.
We may also want to advise them to 'Export your data before doing this in case you do not like the results'.
This is probably worth doing before release...any thoughts?
EL: I've made it so it finishes the activity when the thread finishes. I don't think the notification is necessary at this stage.
I get a (correctly caught) null pointer exception when going from into the catalogue view. Line 1398 (BookCatalogue.java - my HEAD). Are those intents still being used?
Found it. Happend when cancelling out of editing an existing book. I believe it is fixed now.
That seems like the best option. Though when the user enters the new key, the app should test it before completely accepting it. Given the complexity of the key, the likelyhood of making a mistake when entering it is rather high.
- The scanner and book search screens remain active after a book has been added or a search fails. It was viewed that this more closely represents the work-flow of people adding or scanning books.
- Displays a progress dialog while searching for a book on the internet.
- Adding by Amazon's ASIN is supported on the "Add by ISBN" page
- Ensure that search results can now be sorted correctly. Expanding, eg, an author name in search results will just show matching books.
- Preserves *all* open groups when closing application.
- Displays square brackets around the series name when displaying a list of books.
- Changed the ISBN data entry screen when the device is in landscape mode.
- Unsaved edits are retained when rotating the screen.
- Bug fixes for the 'collapse/expand' button, series selection/de-selection
- Bug fixes for sorting of book titles, series and authors.
- Suggestions available when searching
- user-selectable fields when reloading data from internet (eg. just update authors).
- Multiple Authors per book
Editing a book now displays an author button which takes the user to a new activity for managing the authors of this book.
- Multiple Series per book
Editing a book now displays an author button which takes the user to a new activity for managing the authors of this book.
- Fetches series (and other stuff) from LibraryThing
- Does concurrent ISBN searches at Amazon, Google and LibraryThing (it's faster)
- Import & Export improvements
- Duplicate books allowed, with a warning message
- Can now make global changes to Author and Series
Access this feature via the catalogue screen; long-clock on an author or series name Editing can also be accessed while editing series or authors in an individual books. Series can only be deleted from the catalogue view. Authors can not be deleted. It is recommeneded that author deletions be done by changing the author name to match another existing author; this will result in the two authors being merged.
- Can replace a cover thumbnail from a different edition via LibraryThing.
Access this via long-clicking the cover while editing the book. The 'replace thumbnail...' option allows 3 possibilities including this new one. It will display a gallery of thumbnails; clicking on the small thumbnail will display a larger version. Clicking on the larger version will select it.
This section will be updated from the change log at a later date...
- Allow Duplicates: https://github.com/eleybourn/Book-Catalogue/issues#issue/104
- Multiple Authors:
https://github.com/eleybourn/Book-Catalogue/issues#issue/8 - Populating Series:
https://github.com/eleybourn/Book-Catalogue/issues#issue/9 - Multiple Series:
https://github.com/eleybourn/Book-Catalogue/issues#issue/101 - Maxi-Series (via Multiple Series):
https://github.com/eleybourn/Book-Catalogue/issues#issue/105 - Author replace-all:
https://github.com/eleybourn/Book-Catalogue/issues#issue/126 - Defect Logger:
https://github.com/eleybourn/Book-Catalogue/issues#issue/178 - Removed Contacts permission:
https://github.com/eleybourn/Book-Catalogue/issues#issue/179 - Reduced auto-correction:
https://github.com/eleybourn/Book-Catalogue/issues#issue/182 - Edit thumb wipes edits:
https://github.com/eleybourn/Book-Catalogue/issues#issue/183