-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix environment initialization #28
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,7 @@ def run(required_events_count, required_run_time, input_lines) | |
puts("launching #{command.join(" ")} #{required_events_count} #{required_run_time}") if @debug | ||
stats = LogStash::PerformanceMeter::Stats.new | ||
real_events_count = 0 | ||
Open3.popen3(*@command) do |i, o, e| | ||
Open3.popen3({:BUNDLE_BIN_PATH => "", :BUNDLE_GEMFILE => "", :RUBYOPT => ""}, *@command) do |i, o, e| | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like this change, good idea. Can we make this options passed throught a var? something like
and then have
what do you think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure |
||
puts("sending initial event") if @debug | ||
start_time = Benchmark.realtime do | ||
i.puts(INITIAL_MESSAGE) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understood you properly, with this change you actually make this examples executable, isn't? I always thought this would be just examples, not intended to be runnable. What do you think?
by default the gem include the default configs, see https://github.com/elastic/logstash-performance-testing/blob/master/lib/lsperfm/defaults/suite.rb that are actually executable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I did not even see the
lib/lsperfm/defaults
... this is weird. why have both? this is uselessly duplicated. I think it should all be put into the examples dir and be runnable from there?