fix environment initialization #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,7 @@ def run(required_events_count, required_run_time, input_lines) | |||
| puts("launching #{command.join(" ")} #{required_events_count} #{required_run_time}") if @debug | |||
| stats = LogStash::PerformanceMeter::Stats.new | |||
| real_events_count = 0 | |||
| Open3.popen3(*@command) do |i, o, e| | |||
| Open3.popen3({:BUNDLE_BIN_PATH => "", :BUNDLE_GEMFILE => "", :RUBYOPT => ""}, *@command) do |i, o, e| | |||
There was a problem hiding this comment.
I like this change, good idea. Can we make this options passed throught a var? something like
ENV_OPTS = {:BUNDLE_BIN_PATH => "", :BUNDLE_GEMFILE => "", :RUBYOPT => ""}
and then have
Open3.popen3(ENV_OPTS, *@command)....
what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two fixes:
1- an env hash is passed to popen3 to make sure to reset any bundler settings to not interfere with the launched app. this allow launching an external logstash from the performance testing dir, for example:
bundle exec bin/lsperfm examples/suite/basic_performance_quick.rb /Users/colin/dev/src/elasticsearch/logstash2- correctly sets path for suites configs.