[Canvas] Replace squel with safe-squel #97169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poffdeluxe
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
This was referenced Apr 14, 2021
Closed
|
Would it be possible to backport this to 7.12.x as well? |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 28, 2021
* Replace squel with safe-squel * Update squel import name Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 28, 2021
* Replace squel with safe-squel * Update squel import name Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Apr 28, 2021
* Replace squel with safe-squel * Update squel import name Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Poff Poffenberger <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Apr 28, 2021
* Replace squel with safe-squel * Update squel import name Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Poff Poffenberger <[email protected]>
poffdeluxe
added a commit
that referenced
this pull request
Apr 28, 2021
* Replace squel with safe-squel * Update squel import name Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # package.json
watson
pushed a commit
to watson/kibana
that referenced
this pull request
Jun 16, 2021
* Replace squel with safe-squel * Update squel import name Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # package.json # x-pack/plugins/canvas/canvas_plugin_src/functions/server/esdocs.ts # yarn.lock
watson
added a commit
that referenced
this pull request
Jun 16, 2021
* Replace squel with safe-squel * Update squel import name Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # package.json # x-pack/plugins/canvas/canvas_plugin_src/functions/server/esdocs.ts # yarn.lock Co-authored-by: Poff Poffenberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the squel package with safe-squel as a quick fix for 7.13 until we can evaluate a better alternative (or remove the need for a sql package at all)
Fixes #94199