Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Replace or remove safe-squel/squel library dependency #97170

Closed
poffdeluxe opened this issue Apr 14, 2021 · 2 comments
Closed

[Canvas] Replace or remove safe-squel/squel library dependency #97170

poffdeluxe opened this issue Apr 14, 2021 · 2 comments
Labels
Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture

Comments

@poffdeluxe
Copy link
Contributor

Canvas's esdocs expression function uses the squel library to create a select sql statement that we then pass to ES SQL (The reason we convert it to sql is because the ES SQL response includes the types of the returned columns which is helpful for the expression).

For a quick fix, we can replace squel with safe-squel (#97169) but we should investigate a better replacement (either a maintained library or remove the need for a SQL library entirely)
@poffdeluxe poffdeluxe added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture Feature:Canvas labels Apr 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@poffdeluxe poffdeluxe mentioned this issue Apr 14, 2021
Closed
@poffdeluxe poffdeluxe changed the title [Canvas] Replace or remove squel library [Canvas] Replace or remove safe-squel/squel library dependency Apr 14, 2021
@cqliu1 cqliu1 added loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Mar 23, 2023
@nreese
Copy link
Contributor

nreese commented Apr 6, 2023

Closed as not planned

@nreese nreese closed this as completed Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nreese @poffdeluxe @cqliu1 @elasticmachine