Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.9] fix 'Download CSV' returns no data when panel has custom time range outside timerange of global time picker (#163887) #164238

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.9:

Questions ?

Please refer to the Backport tool documentation

…utside timerange of global time picker (elastic#163887)

Closes elastic#163614

PR resolves issue by only adding global time filter to CSV export body
when saved search embeddable does not have time range.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 53e803e)
@nreese
Copy link
Contributor

nreese commented Aug 18, 2023

@elasticmachine merge upstream

@kibanamachine kibanamachine merged commit 2774922 into elastic:8.9 Aug 18, 2023
1 check passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 67 68 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 424.7KB 424.7KB +69.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 42.7KB 42.8KB +85.0B
Unknown metric groups

API count

id before after diff
discover 87 88 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 497 501 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nreese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants