Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 'Download CSV' returns no data when panel has custom time range outside timerange of global time picker #163887

Merged
merged 10 commits into from
Aug 17, 2023
Merged

fix 'Download CSV' returns no data when panel has custom time range outside timerange of global time picker #163887

merged 10 commits into from
Aug 17, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 14, 2023 •
edited by kibanamachine
Loading

Closes #163614

PR resolves issue by only adding global time filter to CSV export body when saved search embeddable does not have time range.

@nreese
Copy link
Contributor Author

nreese commented Aug 15, 2023

@elasticmachine merge upstream

@nreese nreese marked this pull request as ready for review August 15, 2023 14:05
@nreese nreese requested review from a team as code owners August 15, 2023 14:05
@nreese nreese added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.10.0 v8.9.2 labels Aug 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Aug 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

rshen91
rshen91 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporting changes LGTM thanks for this fix! Tested locally

@nreese
Copy link
Contributor Author

nreese commented Aug 17, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Cypress Tests #1 / Overflow items Network stats and tables Shows Hover actions for more items in the popover Shows Hover actions for more items in the popover

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 51 52 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 557.9KB 557.9KB +69.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 43.1KB 43.1KB +85.0B
Unknown metric groups

API count

id before after diff
discover 78 79 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nreese

davismcphee
davismcphee approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested locally, works as expected. Thanks for fixing!

@nreese nreese added the v8.11.0 label Aug 17, 2023
@nreese nreese merged commit 53e803e into elastic:main Aug 17, 2023
2 checks passed
@kibanamachine kibanamachine mentioned this pull request Aug 17, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 17, 2023
@nreese
fix 'Download CSV' returns no data when panel has custom time range o…
42da150 
…utside timerange of global time picker (elastic#163887)

Closes elastic#163614

PR resolves issue by only adding global time filter to CSV export body
when saved search embeddable does not have time range.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 53e803e)
kibanamachine added a commit that referenced this pull request Aug 17, 2023
@kibanamachine @nreese
[8.10] fix 'Download CSV' returns no data when panel has custom time …
255dfa4 
…range outside timerange of global time picker (#163887) (#164237)

# Backport

This will backport the following commits from `main` to `8.10`:
- [fix 'Download CSV' returns no data when panel has custom time range
outside timerange of global time picker
(#163887)](#163887)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-17T22:37:12Z","message":"fix
'Download CSV' returns no data when panel has custom time range outside
timerange of global time picker (#163887)\n\nCloses
https://github.com/elastic/kibana/issues/163614\r\n\r\nPR resolves issue
by only adding global time filter to CSV export body\r\nwhen saved
search embeddable does not have time
range.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"53e803e42c5c9de73e60ae95cff13d17bab09f26","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Team:DataDiscovery","Team:SharedUX","v8.10.0","v8.11.0","v8.9.2"],"number":163887,"url":"https://github.com/elastic/kibana/pull/163887","mergeCommit":{"message":"fix
'Download CSV' returns no data when panel has custom time range outside
timerange of global time picker (#163887)\n\nCloses
https://github.com/elastic/kibana/issues/163614\r\n\r\nPR resolves issue
by only adding global time filter to CSV export body\r\nwhen saved
search embeddable does not have time
range.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"53e803e42c5c9de73e60ae95cff13d17bab09f26"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163887","number":163887,"mergeCommit":{"message":"fix
'Download CSV' returns no data when panel has custom time range outside
timerange of global time picker (#163887)\n\nCloses
https://github.com/elastic/kibana/issues/163614\r\n\r\nPR resolves issue
by only adding global time filter to CSV export body\r\nwhen saved
search embeddable does not have time
range.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"53e803e42c5c9de73e60ae95cff13d17bab09f26"}},{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Aug 17, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 17, 2023
@nreese
fix 'Download CSV' returns no data when panel has custom time range o…
9b33694 
…utside timerange of global time picker (elastic#163887)

Closes elastic#163614

PR resolves issue by only adding global time filter to CSV export body
when saved search embeddable does not have time range.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 53e803e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 18, 2023
@kibanamachine @nreese
[8.9] fix 'Download CSV' returns no data when panel has custom time r…
2774922 
…ange outside timerange of global time picker (#163887) (#164238)

# Backport

This will backport the following commits from `main` to `8.9`:
- [fix 'Download CSV' returns no data when panel has custom time range
outside timerange of global time picker
(#163887)](#163887)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-17T22:37:12Z","message":"fix
'Download CSV' returns no data when panel has custom time range outside
timerange of global time picker (#163887)\n\nCloses
https://github.com/elastic/kibana/issues/163614\r\n\r\nPR resolves issue
by only adding global time filter to CSV export body\r\nwhen saved
search embeddable does not have time
range.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"53e803e42c5c9de73e60ae95cff13d17bab09f26","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Team:DataDiscovery","Team:SharedUX","v8.10.0","v8.11.0","v8.9.2"],"number":163887,"url":"https://github.com/elastic/kibana/pull/163887","mergeCommit":{"message":"fix
'Download CSV' returns no data when panel has custom time range outside
timerange of global time picker (#163887)\n\nCloses
https://github.com/elastic/kibana/issues/163614\r\n\r\nPR resolves issue
by only adding global time filter to CSV export body\r\nwhen saved
search embeddable does not have time
range.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"53e803e42c5c9de73e60ae95cff13d17bab09f26"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163887","number":163887,"mergeCommit":{"message":"fix
'Download CSV' returns no data when panel has custom time range outside
timerange of global time picker (#163887)\n\nCloses
https://github.com/elastic/kibana/issues/163614\r\n\r\nPR resolves issue
by only adding global time filter to CSV export body\r\nwhen saved
search embeddable does not have time
range.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"53e803e42c5c9de73e60ae95cff13d17bab09f26"}},{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

@rshen91 rshen91 rshen91 approved these changes

Assignees

@nreese nreese

Labels
release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.9.2 v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
6 participants
@nreese @elasticmachine @kibana-ci @kibanamachine @rshen91 @davismcphee